fix: stop thread pools when an error occurs during startup#3107
Merged
csviri merged 2 commits intooperator-framework:mainfrom Jan 7, 2026
Merged
fix: stop thread pools when an error occurs during startup#3107csviri merged 2 commits intooperator-framework:mainfrom
csviri merged 2 commits intooperator-framework:mainfrom
Conversation
Collaborator
|
@lion7 thank you for the PR. The tests unfortunatelly fail, could you pls take a look, in case I can check too a bit later. |
Contributor
Author
|
@csviri I altered the order a bit so the |
xstefank
approved these changes
Jan 5, 2026
Collaborator
|
Thank you @lion7 , could you pls also add an integration test for the base API: Where without the junit extension you just create an |
metacosm
approved these changes
Jan 6, 2026
Contributor
Author
|
I added a unit test per your suggestion |
Signed-off-by: Gerard de Leeuw <gdeleeuw@leeuwit.nl>
Signed-off-by: Gerard de Leeuw <gdeleeuw@leeuwit.nl>
Collaborator
|
The CI failures are related to some github networking issue (occured also before), I will re-run it bit later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3099
Tested by running with a locally built snapshot, it fixed the issue.