feat: improve style of index.php file#1598
Merged
Conversation
0f70017 to
4eca07c
Compare
4eca07c to
856a8a1
Compare
Member
|
LGTM — it would be nice to add a screenshot to the PR description, so people don’t have to build it to see what it looks like. |
Contributor
|
that looks really good 🎉 |
Member
|
Merci Laury, beautiful as usual! |
|
Would renaming it from |
Member
|
It's definitely a test page 😅 |
henderkes
pushed a commit
to mhpcc/frankenphp
that referenced
this pull request
Jun 5, 2025
* feat: improve style of index.php file * feat: remove assets folder * Update index.php * Update index.php --------- Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.