feat(scaling): add logs on up and down scaling#1695
Merged
Conversation
b3c28aa to
4621450
Compare
7c6b6d7 to
a4b0f31
Compare
dunglas
requested changes
Jun 27, 2025
a4b0f31 to
e361321
Compare
Member
Author
|
PR updated with your suggestions. Thanks! |
dunglas
requested changes
Jun 27, 2025
scaling.go
Outdated
| // convert threads to inactive if they have been idle for too long | ||
| if thread.state.is(stateReady) && waitTime > maxThreadIdleTime.Milliseconds() { | ||
| logger.LogAttrs(context.Background(), slog.LevelDebug, "auto-converting thread to inactive", slog.Int("threadIndex", thread.threadIndex)) | ||
| logger.LogAttrs(context.Background(), slog.LevelInfo, "downscaling thread", slog.Int("thread", thread.threadIndex), slog.Int64("wait_time", waitTime), slog.Int("num_threads", len(autoScaledThreads)-1)) |
Member
There was a problem hiding this comment.
Nit: shouldn't we log after having done the work? (so the -1 will not be necessary)
Member
Author
There was a problem hiding this comment.
We can! I chose the way that brings the smallest diff but totally fine with it
Member
There was a problem hiding this comment.
(Logging can be slow, depending on the log backend, let's do the actual work first)
e361321 to
47a8581
Compare
dunglas
approved these changes
Jun 30, 2025
47a8581 to
228ba71
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would help better understand optimal scaling parameters per application
cc @soyuka