fix: forwards php_server root to try_files#1729
Merged
Conversation
Contributor
Author
|
This behavior is probably also broken in the php_fast_cgi implementation |
Contributor
|
Looks good, we should also try to upstream this to Caddy. |
henderkes
reviewed
Jul 7, 2025
| TryFiles: tryFiles, | ||
| TryPolicy: tryPolicy, | ||
| SplitPath: extensions, | ||
| Root: phpsrv.Root, |
Contributor
There was a problem hiding this comment.
one question though because I currently can't test it - this still falls back to Caddy's root if the one in phpsrv is empty?
Contributor
Author
There was a problem hiding this comment.
Yeah it will fallback, an empty string is the default in the struct (otherwise tests would also fail)
Contributor
Author
There was a problem hiding this comment.
I'll add some more tests for all cases
Contributor
Author
|
Hmm not sure if this is also an issue upstream since the |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #1723
The root defined in
php_serverwas never really forwarded totry_files, which led to potentially confusing behavior where thefile_serverroot (coming from php_server) and thetry_filesroot (coming from the caddy route) would differ.