Fix: Allows headers without whitespace after colon.#1741
Merged
Conversation
Member
|
It will likely be faster to split using a regex than calling split 2 times. |
Contributor
Author
|
The performance will be the same in this case for 'well formed' headers, but worse for non-well formed headers. I think this could actually be made faster though by scanning for the colon in c and then calling |
Contributor
Author
|
I rewrote the header splitting to ignore all whitespaces after ':', it will now also directly allocate key and value from the This is a bit faster than Test with |
dunglas
approved these changes
Jul 16, 2025
Member
|
Good one! Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1738
rfc7230 apparently doesn't explicitly disallow headers without a whitespace after the colon.
This PR allows both ways of calling the PHP ´header` function, since apparently FPM/nginx also allows them: