Skip to content

ci: add PHP 8.5's official release#2006

Merged
dunglas merged 5 commits intophp:mainfrom
0x346e3730:php-8.5
Nov 21, 2025
Merged

ci: add PHP 8.5's official release#2006
dunglas merged 5 commits intophp:mainfrom
0x346e3730:php-8.5

Conversation

@0x346e3730
Copy link
Contributor

@0x346e3730 0x346e3730 commented Nov 21, 2025

No description provided.

@0x346e3730
Copy link
Contributor Author

0x346e3730 commented Nov 21, 2025 •
edited
Loading

Would be cool if someone could trigger a build & publish of the 8.5 manually before the next run in 23h30m, so we can start using it today rather that tomorrow :)
Nevermind images for 8.5 just have been published (pointing at RC5)

alexandre-daubois
alexandre-daubois requested changes Nov 21, 2025
View reviewed changes
Copy link
Member

@alexandre-daubois alexandre-daubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please also remove the experimental: true setting in the CI for PHP 8.5 🙂

henderkes
henderkes approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@henderkes henderkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@0x346e3730
Copy link
Contributor Author

0x346e3730 commented Nov 21, 2025

Looks like there is some outage on GitHub's side causing jobs to fail (failing to call github's API and cache)

@alexandre-daubois
Copy link
Member

alexandre-daubois commented Nov 21, 2025

@dunglas Ah yes, I wasn't sure if you wanted to make these changes right now like setting 8.5 as the default version everywhere right away. Thanks!

henderkes
henderkes requested changes Nov 21, 2025
View reviewed changes
docker-bake.hcl

variable DEFAULT_PHP_VERSION {
default = "8.4"
default = "8.5"
Copy link
Contributor

@henderkes henderkes Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're keeping the default at 8.4 at static-php-cli for now, because too many extensions aren't yet compatible with 8.5 in their latest stable release

Copy link
Member

@dunglas dunglas Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For SPC it makes sense, but for Docker, as we provide images for all supported versions, we can sync defaults with the official images.

@alexandre-daubois alexandre-daubois self-requested a review November 21, 2025 10:55
@dunglas @henderkes
Update docker.md
2fdd447 
Co-authored-by: Marc <m@pyc.ac>
@dunglas dunglas merged commit 01beb66 into php:main Nov 21, 2025
62 of 72 checks passed
@dunglas
Copy link
Member

dunglas commented Nov 21, 2025

Thanks @0x346e3730!

@0x346e3730 0x346e3730 deleted the php-8.5 branch November 21, 2025 12:57
@0x346e3730
Copy link
Contributor Author

0x346e3730 commented Nov 21, 2025

Thank you all for getting this merged quickly, will allow me to play around with 8.5 this week-end 🫶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dunglas dunglas dunglas left review comments

@henderkes henderkes henderkes approved these changes

@alexandre-daubois alexandre-daubois Awaiting requested review from alexandre-daubois

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0x346e3730 @alexandre-daubois @dunglas @henderkes