fix(caddy): use default patterns when hot_reload is alone#2081
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where using the hot_reload directive alone (without inline patterns or a block) would not initialize the hot reload configuration, preventing default patterns from being applied. The fix ensures that the HotReload struct is always initialized when the directive is encountered, allowing the configureHotReload function to properly apply default watch patterns when none are explicitly specified.
- Removes conditional initialization logic that prevented standalone
hot_reloadusage - Ensures
HotReloadconfig is always created when parsing thehot_reloaddirective - Removes redundant nil check that's no longer needed after the initialization change
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.