PDO_DBLIB: Quote LOB arguments as binary literals#10343
Open
NattyNarwhal wants to merge 2 commits intophp:masterfrom
Open
PDO_DBLIB: Quote LOB arguments as binary literals#10343NattyNarwhal wants to merge 2 commits intophp:masterfrom
NattyNarwhal wants to merge 2 commits intophp:masterfrom
Conversation
If the user is specifying a PDO::PARAM_LOB, there's a good chance that it's a binary file (i.e. an image), that is too fragile to survive in a string, as escaping it is insufficient. Because PDO_DBLIB relies on PDO to fill in a parameterized query and submits the filled string to the server, it ends up mangling the query. This adds logic in the PDO_DBLIB quoter to handle binary parameters by using the SQL Server binary literal syntax (a hex string that begins with `0x`). This resolves the issue because PDO consults the quoter for filling in the query string.
This makes sure that a PDO::PARAM_LOB parameter gets converted to a binary literal when doing the substitution for the query.
Member
Author
|
After discussing this with Derrick, we brought up the possibility of putting this behind a constant (PDO_DBLIB specific, but could be useful for other drivers?) or a feature flag (in the connection string, INI options should be avoided). Also worth mentioning that the Postgres PDO driver does special-case binary strings in the quoter under |
Member
Author
|
Someone emailed me about wanting a PARAM_BINARY in PDO_ODBC, to work around driver issues with strings as inputs/outputs for binary columns. I'm tempted to generalize this for other drivers. |
NattyNarwhal
added a commit
to NattyNarwhal/php-src
that referenced
this pull request
Jul 11, 2023
Original text: >If the user is specifying a PDO::PARAM_LOB, there's a good chance >that it's a binary file (i.e. an image), that is too fragile to >survive in a string, as escaping it is insufficient. Because >PDO_DBLIB relies on PDO to fill in a parameterized query and >submits the filled string to the server, it ends up mangling the >query. > >This adds logic in the PDO_DBLIB quoter to handle binary parameters >by using the SQL Server binary literal syntax (a hex string that >begins with `0x`). This resolves the issue because PDO consults the >quoter for filling in the query string.
NattyNarwhal
added a commit
to NattyNarwhal/php-src
that referenced
this pull request
Nov 8, 2024
Original text: >If the user is specifying a PDO::PARAM_LOB, there's a good chance >that it's a binary file (i.e. an image), that is too fragile to >survive in a string, as escaping it is insufficient. Because >PDO_DBLIB relies on PDO to fill in a parameterized query and >submits the filled string to the server, it ends up mangling the >query. > >This adds logic in the PDO_DBLIB quoter to handle binary parameters >by using the SQL Server binary literal syntax (a hex string that >begins with `0x`). This resolves the issue because PDO consults the >quoter for filling in the query string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user is specifying a PDO::PARAM_LOB, there's a good chance that it's a binary file (i.e. an image), that is too fragile to survive in a string, as escaping it is insufficient. Because PDO_DBLIB relies on PDO to fill in a parameterized query and submits the filled string to the server, it ends up mangling the query.
This adds logic in the PDO_DBLIB quoter to handle binary parameters by using the SQL Server binary literal syntax (a hex string that begins with
0x). This resolves the issue because PDO consults the quoter for filling in the query string.I've also added a unit test for this.
Questions not raised in the commit:
PDO::PARAM_LOBthe best option for this? I picked this because the end-user I was working with (as did I) expected binary behaviour out of it, but that might be too much of an assumption, especially since there's not really LOBs involved, just binaries. Would aPARAM_BINARYmake sense? If so, as a modifier or its own type? Added to base PDO or just DBLIB?Resolves GH-10312.