Skip to content

Strip suffix when comparing versions#487

Merged
asgrim merged 1 commit intophp:1.3.xfrom
mbeccati:fix-php-version-check
Jan 26, 2026
Merged

Strip suffix when comparing versions#487
asgrim merged 1 commit intophp:1.3.xfrom
mbeccati:fix-php-version-check

Conversation

@mbeccati
Copy link
Contributor

1) Php\PieUnitTest\Platform\TargetPhp\PhpBinaryPathTest::testVersionFromCurrentProcess
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'8.5.3-dev'
+'8.5.3'

:-)

@mbeccati mbeccati force-pushed the fix-php-version-check branch from 1797e51 to 4a95fae Compare January 21, 2026 09:29
@mbeccati mbeccati force-pushed the fix-php-version-check branch from 4a95fae to 7df9e3e Compare January 21, 2026 09:34
@asgrim asgrim self-requested a review January 26, 2026 10:44
@asgrim asgrim added the enhancement New feature or request label Jan 26, 2026
@asgrim asgrim self-assigned this Jan 26, 2026
@asgrim asgrim added this to the 1.3.7 milestone Jan 26, 2026
@asgrim asgrim merged commit a8bf21c into php:1.3.x Jan 26, 2026
22 checks passed
@mbeccati mbeccati deleted the fix-php-version-check branch January 26, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants