Skip to content

Patch ext/gd in PHP < 7.4 for compatibility with newer Debian distros#1044

Merged
morozov merged 1 commit intophpbrew:masterfrom
morozov:issues/1033
Oct 9, 2019
Merged

Patch ext/gd in PHP < 7.4 for compatibility with newer Debian distros#1044
morozov merged 1 commit intophpbrew:masterfrom
morozov:issues/1033

Conversation

@morozov
Copy link
Contributor

@morozov morozov commented Oct 5, 2019

  1. Patch ext/gd with the patch from Arch Linux.
  2. Extract ./buildconf --force into a reusable component.

Fixes #1033.

@coveralls
Copy link

coveralls commented Oct 5, 2019

Coverage Status

Coverage decreased (-0.2%) to 40.959% when pulling 6dc11ac on morozov:issues/1033 into bceaee1 on phpbrew:master.

@morozov
Copy link
Contributor Author

morozov commented Oct 5, 2019

@c9s could you please take a look at this patch and the others I filed recently?

@morozov morozov requested review from c9s and jhdxr October 5, 2019 21:53
@jhdxr
Copy link
Member

jhdxr commented Oct 8, 2019

I don't have 7.4 on hand, so I may test it tmr.

It's a good idea to add 7.4 into travis if possible, but I guess it's very challenging since there are so many changes in 7.4.

@morozov
Copy link
Contributor Author

morozov commented Oct 8, 2019

I don't have 7.4 on hand, so I may test it tmr.

@jhdxr it should be a version older than 7.4. Building PHP 7.4 works fine without the patch. The details are in the related issue.

@jhdxr
Copy link
Member

jhdxr commented Oct 9, 2019

The patch is OK for me.

My only concern is if we should include the patch in our repo, since the remote source is not in our control, which could be considered as a security risk. in addition, this might be unavailable in intranet.

@morozov
Copy link
Contributor Author

morozov commented Oct 9, 2019

@jhdxr the security risk is mitigated by checking the file hash but in general, I agree. I was just following the approach from the PHP53Patch. Let's merge it as is and then get rid of the two remove patches altogether.

@morozov morozov merged commit 01de616 into phpbrew:master Oct 9, 2019
@morozov morozov deleted the issues/1033 branch October 9, 2019 16:05
@morozov morozov self-assigned this Nov 1, 2019
@morozov morozov added this to the Release 1.24 milestone Nov 27, 2019
@morozov morozov added the Patching PHP Resolving the issue requires patching PHP sources label Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Debian | Ubuntu Improvement Patching PHP Resolving the issue requires patching PHP sources

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The GD extension of PHP older than 7.4 cannot be compiled on Ubuntu 19.04

3 participants