Patch ext/gd in PHP < 7.4 for compatibility with newer Debian distros#1044
Patch ext/gd in PHP < 7.4 for compatibility with newer Debian distros#1044morozov merged 1 commit intophpbrew:masterfrom morozov:issues/1033
Conversation
|
@c9s could you please take a look at this patch and the others I filed recently? |
|
I don't have 7.4 on hand, so I may test it tmr. It's a good idea to add 7.4 into travis if possible, but I guess it's very challenging since there are so many changes in 7.4. |
@jhdxr it should be a version older than 7.4. Building PHP 7.4 works fine without the patch. The details are in the related issue. |
|
The patch is OK for me. My only concern is if we should include the patch in our repo, since the remote source is not in our control, which could be considered as a security risk. in addition, this might be unavailable in intranet. |
|
@jhdxr the security risk is mitigated by checking the file hash but in general, I agree. I was just following the approach from the |
ext/gdwith the patch from Arch Linux../buildconf --forceinto a reusable component.Fixes #1033.