Small fixes in libraries/transformations/global.inc.php #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have a little doubt about these two functions being used by custom transformations done by users and incorporated in their instance of phpMyAdmin, but let's remove them! By the way, I think that the remaining function in global.inc.php could be moved to libraries/transformations.lib.php and global.inc.php could be deleted. If you have time, please have a look. |
lem9
pushed a commit
that referenced
this pull request
Apr 1, 2012
Small fixes in libraries/transformations/global.inc.php
Contributor
Author
|
Done in pull request 12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, I've noticed that the two functions:
PMA_transformation_global_plain($buffer, $options = array(), $meta = '') and
PMA_transformation_global_html($buffer, $options = array(), $meta = '')
are not used anywhere in the project, so I have removed them.
Also, the $meta argument is not used in the third function:
PMA_transformation_global_html_replace($buffer, $options = array(), $meta = '')
so I have removed that argument as well.
The other two commits are for adding a PHPDoc comment to this function and improving readability.
Alex