Closed
Conversation
this will fix the error with HHVM: Fatal error: Uncaught exception 'Exception' with message 'Port is not numeric'
Contributor
|
Please read https://github.com/phpmyadmin/phpmyadmin/blob/master/DCO to see what a Signed-Off-By line should look like. |
Author
|
Hello, |
nijel
added a commit
that referenced
this pull request
Mar 5, 2015
The port always should be integer. See PR #1530 Signed-off-by: Michal Čihař <michal@cihar.com>
Contributor
|
Anyway forcing the conversion in all cases does not sound like a good idea, the code should rather fail if it gets something unexpected. In 2b23430 I've implemented handling of single value which can cause problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will fix the error with HHVM:
Fatal error: Uncaught exception 'Exception' with message 'Port is not numeric'
Signed-off-by