Skip to content

Comments

Refactor the Engines\Innodb::getPageBufferpool() method#19786

Merged
MauricioFauth merged 4 commits intophpmyadmin:masterfrom
MauricioFauth:Innodb_getPageBufferpool-refactor
Jul 28, 2025
Merged

Refactor the Engines\Innodb::getPageBufferpool() method#19786
MauricioFauth merged 4 commits intophpmyadmin:masterfrom
MauricioFauth:Innodb_getPageBufferpool-refactor

Conversation

@MauricioFauth
Copy link
Member

Use Engines\Innodb\BufferPool value object for Innodb_buffer_pool_* variables.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
@codecov
Copy link

codecov bot commented Jul 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.67%. Comparing base (d42db65) to head (1c386bd).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #19786      +/-   ##
============================================
- Coverage     60.69%   60.67%   -0.02%     
- Complexity    16221    16226       +5     
============================================
  Files           674      675       +1     
  Lines         60369    60377       +8     
============================================
- Hits          36638    36632       -6     
- Misses        23731    23745      +14     
Flag Coverage Δ
unit-8.2-ubuntu-latest ?
unit-8.3-ubuntu-latest 60.66% <100.00%> (?)
unit-8.4-ubuntu-latest 60.65% <100.00%> (-0.04%) ⬇️
unit-8.5-ubuntu-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
@MauricioFauth MauricioFauth force-pushed the Innodb_getPageBufferpool-refactor branch from 1c386bd to 710ae6a Compare July 28, 2025 01:04
@MauricioFauth MauricioFauth merged commit e5acf85 into phpmyadmin:master Jul 28, 2025
42 checks passed
@MauricioFauth MauricioFauth deleted the Innodb_getPageBufferpool-refactor branch July 28, 2025 16:12
@MauricioFauth MauricioFauth self-assigned this Jul 28, 2025
@MauricioFauth MauricioFauth added this to the 6.0.0 milestone Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants