Add support for bacon-qr-code v3#19837
Conversation
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
|
Thank you. |
williamdes
left a comment
There was a problem hiding this comment.
Thank you, I can confirm that on the Debian side v3 is the one packaged but sadly we still lack php-pragmarx-google2fa-qrcode to make it work
This change is still good, and it confirms that v3 will work when the missing library lands out
|
You may have to adjust our release script, it may lack quotes maybe |
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
|
For some reason locally the command a9bc83c was maybe a good idea |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## QA_5_2 #19837 +/- ##
============================================
+ Coverage 49.44% 50.68% +1.23%
- Complexity 16778 16779 +1
============================================
Files 607 607
Lines 69485 69488 +3
============================================
+ Hits 34357 35219 +862
+ Misses 35128 34269 -859
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This seems to work. Setting the input separator to a newline character and separating each package by a new line for PACKAGE in $PACKAGE_LIST
do
PKG_VERSION="$(get_composer_package_version "$PACKAGE")"
PACKAGES_VERSIONS="$PACKAGES_VERSIONS\n$PACKAGE:$PKG_VERSION"
done
echo "* Installing composer packages '$(echo "$PACKAGES_VERSIONS" | tr $'\n' ' ')'"
IFS=$'\n' composer require --no-interaction --update-no-dev $PACKAGES_VERSION |
|
@williamdes all versions worked locally, but I must admit that I have the latest version of composer. Test seems to pass https://github.com/phpmyadmin/phpmyadmin/actions/runs/17363513269/job/49286783009. Let me know which version you prefer the one that is right now or @MoonE approach. |
I think the |
|
Something is not working as expected, I am confused |
|
Only 238d18b worked. |
|
Maybe this will work? NEWLINE=$'\n'
for PACKAGE in $PACKAGE_LIST
do
PKG_VERSION="$(get_composer_package_version "$PACKAGE")"
PACKAGES_VERSIONS="${PACKAGES_VERSIONS}${NEWLINE}${PACKAGE}:${PKG_VERSION}"
done
echo "* Installing composer packages '$(echo "$PACKAGES_VERSIONS" | tr $NEWLINE ' ')'"
IFS=$NEWLINE composer require --no-interaction --update-no-dev $PACKAGES_VERSIONS |
|
238d18b is the way to go with the dash shell, the default shell for -echo "* Installing composer packages '$@'"
+echo "* Installing composer packages '$*'" |
Done. Output looks OK. https://github.com/phpmyadmin/phpmyadmin/actions/runs/17388649338/job/49358987203?pr=19837 |
Description
Before:
before1.mp4
After:
after1.mp4