Remove checkDataProviderData and introduce reportMissingDataProviderReturnType#253
Conversation
6098601 to
5dbdbc3
Compare
|
"ignoreMissing" is a double negative. It requires a lot of mental gymnastics to figure out "do I need true or false for what I want?". That's why AFAIK If it doesn't we need to do some work in phpstan-src to enable that. |
I'm getting with or maybe am I doing it wrong ? |
|
Yeah, that's what I'm talking about, some amends need to be made in phpstan-src first. |
|
Ok, so I'll try to introduce this syntax on phpstan-src (with phpstan/phpstan-src#4512) |
|
You can now take advantage of this here 😊 |
e876871 to
f2e12e1
Compare
Nice, Ci is green |
|
Friendly ping @ondrejmirtes I'd like to use this option :) |
|
Thank you! |
|
@ondrejmirtes , @VincentLanglet how to disable this rule??? I do not have a time (and the desire to be honest) to fix "Found 354 errors" now nor to add them into baseline :| |
|
@LastDragon-ru Do not use bleeding edge, or put them into the baseline. |
Cf #246 (comment)
I did
ignoreMissingDataProviderReturnTyperather thanreportMissingDataProviderReturnTypebecause it allows to writeand I dunno how a syntax
would exists