Named argument detection is scope php-version dependent#3662
Merged
ondrejmirtes merged 3 commits intophpstan:2.0.xfrom Dec 20, 2024
Merged
Named argument detection is scope php-version dependent#3662ondrejmirtes merged 3 commits intophpstan:2.0.xfrom
ondrejmirtes merged 3 commits intophpstan:2.0.xfrom
Conversation
Collaborator
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Nov 25, 2024
|
|
||
| namespace FunctionNamedArguments; | ||
|
|
||
| if (PHP_VERSION_ID < 80000) return; |
Member
There was a problem hiding this comment.
We don't need this here, right? The test should run only on PHP 8+.
Contributor
Author
There was a problem hiding this comment.
the test which uses this file, has error expectations for PHP 7, see
Member
There was a problem hiding this comment.
It doesn't make sense to me. PHP 7.x does not support named arguments so it doesn't make sense to check them?
Contributor
Author
There was a problem hiding this comment.
so do you say I should skip the test on php7, or should the test be made to assert 0 errors on php7?
(and I guess the rule needs adjustments for that)
Contributor
Author
There was a problem hiding this comment.
I went with skipping the tests for now
5f93ffc to
87418b6
Compare
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #3642 (comment)