Update phpstan-phpunit to 2.0.8 by staabm · Pull Request #4490 · phpstan/phpstan-src

staabm · 2025-10-27T15:13:36Z

No description provided.

staabm · 2025-10-27T20:24:02Z

looking at the PHP 7.x errors:

------ ------------------------------------------------------------------ 
  Line   tests/PHPStan/Command/ErrorFormatter/TableErrorFormatterTest.php  
 ------ ------------------------------------------------------------------ 
  44     Named arguments are supported only on PHP 8.0 and later.          
  57     Named arguments are supported only on PHP 8.0 and later.          
  76     Named arguments are supported only on PHP 8.0 and later.          
  95     Named arguments are supported only on PHP 8.0 and later.          
  124    Named arguments are supported only on PHP 8.0 and later.          
  144    Named arguments are supported only on PHP 8.0 and later.          
  180    Named arguments are supported only on PHP 8.0 and later.          
  199    Named arguments are supported only on PHP 8.0 and later.          
  220    Named arguments are supported only on PHP 8.0 and later.          
  241    Named arguments are supported only on PHP 8.0 and later.          
 ------ ------------------------------------------------------------------

I think we have these alternatives to fix these errors:
a) check whether parameters are in correct order and don't error in case the named args are in the right order
b) adjust the tests to not use named args

wdyt?

tests/PHPStan/Type/StringTypeTest.php

tests/PHPStan/Type/UnionTypeTest.php

ondrejmirtes · 2025-10-28T06:36:06Z

About:

Named arguments are supported only on PHP 8.0 and later.

I'd say this is a phpstan-phpunit bug. The rule should match how PHPUnit behaves. Does it always do basically array_values on the args (so that only the order matters), or does it keep named args on PHP 8+?

staabm · 2025-10-28T06:39:48Z

I'd say this is a phpstan-phpunit bug. The rule should match how PHPUnit behaves. Does it always do basically array_values on the args (so that only the order matters), or does it keep named args on PHP 8+?

see

➜  phpunit git:(9.6) ✗ php -v
PHP 7.4.33 (cli) (built: Oct 11 2025 23:03:42) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
➜  phpunit git:(9.6) ✗ cat FooTest.php                                                              
<?php

class FooTest extends \PHPUnit\Framework\TestCase
{

    /**
     * @dataProvider dataParseFileClearCache
     */
    public function testParseFileClearCache(
        int $cachedNodesByStringCountMax,
        int $cachedNodesByStringCountExpected
        ): void
        {
        $this->assertTrue(true);
    }

    /**
     * @return Generator<string, array{cachedNodesByStringCountMax: int,cachedNodesByStringCountExpected: int}>
     */
    public static function dataParseFileClearCache(): Generator
    {
        yield 'even' => [
            'cachedNodesByStringCountMax' => 50,
            'cachedNodesByStringCountExpected' => 50,
        ];

        yield 'odd' => [
            'cachedNodesByStringCountMax' => 51,
            'cachedNodesByStringCountExpected' => 51,
        ];
    }
}
➜  phpunit git:(9.6) ✗ php phpunit FooTest.php
PHPUnit 9.6.29-15-g3ee3d102e by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.33
Configuration: /Users/staabm/workspace/phpunit/phpunit.xml

..                                                                  2 / 2 (100%)

Time: 00:00.001, Memory: 6.00 MB

OK (2 tests, 2 assertions)

staabm · 2025-10-28T06:41:28Z

and here a failling one:

➜  phpunit git:(9.6) ✗ php -v                 
PHP 7.4.33 (cli) (built: Oct 11 2025 23:03:42) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
➜  phpunit git:(9.6) ✗ cat FooTest.php 
<?php

class FooTest extends \PHPUnit\Framework\TestCase
{

    /**
     * @dataProvider dataParseFileClearCache
     */
    public function testParseFileClearCache(
        int $cachedNodesByStringCountMax,
        string $cachedNodesByStringCountExpected
        ): void
        {
        $this->assertTrue(true);
    }

    /**
     * @return Generator<string, array{cachedNodesByStringCountMax: int,cachedNodesByStringCountExpected: int}>
     */
    public static function dataParseFileClearCache(): Generator
    {
        yield 'even' => [
            'cachedNodesByStringCountMax' => 50,
            'cachedNodesByStringCountExpected' => 'abc',
        ];

        yield 'odd' => [
            'cachedNodesByStringCountExpected' => 'def',
            'cachedNodesByStringCountMax' => 51,
        ];
    }
}
➜  phpunit git:(9.6) ✗ php phpunit FooTest.php
PHPUnit 9.6.29-15-g3ee3d102e by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.33
Configuration: /Users/staabm/workspace/phpunit/phpunit.xml

.E                                                                  2 / 2 (100%)

Time: 00:00.002, Memory: 6.00 MB

There was 1 error:

1) FooTest::testParseFileClearCache with data set "odd" ('def', 51)
TypeError: Argument 1 passed to FooTest::testParseFileClearCache() must be of the type int, string given, called in /Users/staabm/workspace/phpunit/src/Framework/TestCase.php on line 1617

/Users/staabm/workspace/phpunit/FooTest.php:9
/Users/staabm/workspace/phpunit/src/Framework/TestCase.php:1617
/Users/staabm/workspace/phpunit/src/Framework/TestCase.php:1223
/Users/staabm/workspace/phpunit/src/Framework/TestResult.php:729
/Users/staabm/workspace/phpunit/src/Framework/TestCase.php:973
/Users/staabm/workspace/phpunit/src/Framework/TestSuite.php:685
/Users/staabm/workspace/phpunit/src/Framework/TestSuite.php:685
/Users/staabm/workspace/phpunit/src/TextUI/TestRunner.php:651
/Users/staabm/workspace/phpunit/src/TextUI/Command.php:146
/Users/staabm/workspace/phpunit/src/TextUI/Command.php:99

ERRORS!
Tests: 2, Assertions: 1, Errors: 1.

staabm · 2025-10-28T06:43:44Z

PHP8.3 on PHPUnit 9.6

➜  phpunit git:(9.6) ✗ php phpunit FooTest.php
PHPUnit 9.6.29-15-g3ee3d102e by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.27
Configuration: /Users/staabm/workspace/phpunit/phpunit.xml

.E                                                                  2 / 2 (100%)

Time: 00:00.002, Memory: 6.00 MB

There was 1 error:

1) FooTest::testParseFileClearCache with data set "odd" ('def', 51)
TypeError: FooTest::testParseFileClearCache(): Argument #1 ($cachedNodesByStringCountMax) must be of type int, string given, called in /Users/staabm/workspace/phpunit/src/Framework/TestCase.php on line 1617

/Users/staabm/workspace/phpunit/FooTest.php:9
/Users/staabm/workspace/phpunit/src/Framework/TestCase.php:1617
/Users/staabm/workspace/phpunit/src/Framework/TestCase.php:1223
/Users/staabm/workspace/phpunit/src/Framework/TestResult.php:729
/Users/staabm/workspace/phpunit/src/Framework/TestCase.php:973
/Users/staabm/workspace/phpunit/src/Framework/TestSuite.php:685
/Users/staabm/workspace/phpunit/src/Framework/TestSuite.php:685
/Users/staabm/workspace/phpunit/src/TextUI/TestRunner.php:651
/Users/staabm/workspace/phpunit/src/TextUI/Command.php:146
/Users/staabm/workspace/phpunit/src/TextUI/Command.php:99

ERRORS!
Tests: 2, Assertions: 1, Errors: 1.

PHP8.3 on PHPUnit 11.5

➜  phpunit git:(11.5) ✗ php phpunit FooTest.php
PHPUnit 11.5.42-27-g32e5fd8bc by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.27
Configuration: /Users/staabm/workspace/phpunit/phpunit.xml

..                                                                  2 / 2 (100%)

Time: 00:00.002, Memory: 10.00 MB

There was 1 PHPUnit test runner deprecation:

1) Metadata found in doc-comment for method FooTest::testParseFileClearCache(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

OK, but there were issues!
Tests: 2, Assertions: 2, PHPUnit Deprecations: 1.

ondrejmirtes · 2025-10-28T06:43:47Z

I don't get it. TableErrorFormatterTest.php works on 7.4.

staabm · 2025-10-28T06:44:17Z

I don't get it. TableErrorFormatterTest.php works on 7.4.

one of my above comments was wrong. I deleted it.

ondrejmirtes · 2025-10-28T06:44:32Z

Also "must be of the type int, string given" doesn't look like named arguments error, just argument type mismatch.

ondrejmirtes · 2025-10-28T06:48:17Z

The thing is - does PHPUnit try to match cachedNodesByStringCountExpected against parameter name on PHP 8+ or is it always just about key order? The rule should match that.

staabm · 2025-10-28T07:04:34Z

PHPUnit 9.6 implementation is here: https://github.com/sebastianbergmann/phpunit/blob/3ee3d102eef928587fc72d166271d2fb1a8dfa2b/src/Framework/TestCase.php#L1617
PHPUnit 10.5 same as in 9.6: https://github.com/sebastianbergmann/phpunit/blob/c66b7d664c2b3b0b579972ffe8285809f5e79a8b/src/Framework/TestCase.php#L1548

PHPUnit 11.5 slightly different: https://github.com/sebastianbergmann/phpunit/blob/32e5fd8bccf79567f281e2191a0304d396c08065/src/Framework/TestCase.php#L1657
PHPUnit 12.5 same as in 11.5: https://github.com/sebastianbergmann/phpunit/blob/59a94243e963991e7606690609d9674f8b3b9165/src/Framework/TestCase.php#L1325
PHPUnit 13.x same as in 11.5 https://github.com/sebastianbergmann/phpunit/blob/a96c61dfc29d9827155ee9771454967bd57bef5d/src/Framework/TestCase.php

staabm · 2025-10-28T08:37:49Z

ok, I finally did more testing and have a better idea.

I think PHPUnit 9.x/10.x does not at all support named arguments from data-providers (no matter PHP version).
starting with PHPUnit 11.x named arguments are supported

ondrejmirtes · 2025-10-28T08:39:56Z

The rule should reflect that, it'd be very useful!

ondrejmirtes · 2025-10-29T08:51:06Z

Thank you!

Update phpstan-phpunit to 2.0.8

9cac8fb

ondrejmirtes requested changes Oct 28, 2025

View reviewed changes

tests/PHPStan/Type/StringTypeTest.php Show resolved Hide resolved

tests/PHPStan/Type/StringTypeTest.php Show resolved Hide resolved

tests/PHPStan/Type/UnionTypeTest.php Show resolved Hide resolved

tests/PHPStan/Type/UnionTypeTest.php Show resolved Hide resolved

assert parameter types

121c7c9

This was referenced Oct 28, 2025

Refactor PHPUnitVersionDetector to ease different major version checks phpstan/phpstan-phpunit#248

Merged

PHPUnit 9.x/10.x does not at all support named arguments from data-providers phpstan/phpstan-phpunit#250

Merged

Update composer.lock

2126477

staabm force-pushed the phpunit branch from 8a7bd4e to 2126477 Compare October 29, 2025 08:46

ondrejmirtes merged commit 3578a23 into phpstan:2.1.x Oct 29, 2025
538 of 552 checks passed

staabm deleted the phpunit branch October 29, 2025 08:51

Conversation

staabm commented Oct 27, 2025

Uh oh!

staabm commented Oct 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ondrejmirtes commented Oct 28, 2025

Uh oh!

staabm commented Oct 28, 2025

Uh oh!

staabm commented Oct 28, 2025

Uh oh!

staabm commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ondrejmirtes commented Oct 28, 2025

Uh oh!

staabm commented Oct 28, 2025

Uh oh!

ondrejmirtes commented Oct 28, 2025

Uh oh!

ondrejmirtes commented Oct 28, 2025

Uh oh!

staabm commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

staabm commented Oct 28, 2025

Uh oh!

ondrejmirtes commented Oct 28, 2025

Uh oh!

Uh oh!

ondrejmirtes commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

staabm commented Oct 28, 2025 •

edited

Loading

staabm commented Oct 28, 2025 •

edited

Loading