Skip to content

Update theseer/tokenizer to 1.3.1#4565

Merged
ondrejmirtes merged 2 commits intophpstan:2.1.xfrom
staabm:up-tok
Nov 18, 2025
Merged

Update theseer/tokenizer to 1.3.1#4565
ondrejmirtes merged 2 commits intophpstan:2.1.xfrom
staabm:up-tok

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Nov 18, 2025 •
edited
Loading

running PHPUnit 11.5.23 on phpstan-src@5a24138b9a with
time XDEBUG_MODE=coverage blackfire run php vendor/bin/phpunit --coverage-xml=tmp/coverage-xml tests/PHPStan/Rules/Api/

using theseer/tokenizer 1.2.3

➜  phpstan-src git:(2.1.x) ✗ time XDEBUG_MODE=coverage blackfire run php vendor/bin/phpunit --coverage-xml=tmp/coverage-xml tests/PHPStan/Rules/Api/
The profile will be stored in your Personal environment. The "--environment" option can be used to specify the target environment.
PHPUnit 11.5.43 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.27 with Xdebug 3.4.7
Configuration: /Users/staabm/workspace/phpstan-src/phpunit.xml
Random Seed:   1763446832

.............................................                     45 / 45 (100%)

Time: 00:34.220, Memory: 230.50 MB

OK (45 tests, 45 assertions)

Generating code coverage report in PHPUnit XML format ... done [00:42.036]

using theseer/tokenizer 1.3.1

➜  phpstan-src git:(2.1.x) ✗ time XDEBUG_MODE=coverage blackfire run php vendor/bin/phpunit --coverage-xml=tmp/coverage-xml tests/PHPStan/Rules/Api/
The profile will be stored in your Personal environment. The "--environment" option can be used to specify the target environment.
PHPUnit 11.5.43 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.27 with Xdebug 3.4.7
Configuration: /Users/staabm/workspace/phpstan-src/phpunit.xml
Random Seed:   1763446937

.............................................                     45 / 45 (100%)

Time: 00:34.075, Memory: 232.50 MB

OK (45 tests, 45 assertions)

Generating code coverage report in PHPUnit XML format ... done [00:24.117]

=>

- Generating code coverage report in PHPUnit XML format ... done [00:42.036]
+ Generating code coverage report in PHPUnit XML format ... done [00:24.117]

the perf benefit seems to only happen on blackfire builds though :-/

@staabm
Copy link
Contributor Author

staabm commented Nov 18, 2025

btw: interessting observation.

running the suite with pcov is not just only faster while running the test-suite but also when generating the xml report

➜  phpstan-src git:(2.1.x) ✗ time php vendor/bin/phpunit --coverage-xml=tmp/coverage-xml tests/PHPStan/Rules/Api/                     
PHPUnit 11.5.43 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.27 with PCOV 1.0.12
Configuration: /Users/staabm/workspace/phpstan-src/phpunit.xml
Random Seed:   1763448815

.............................................                     45 / 45 (100%)

Time: 00:04.192, Memory: 186.00 MB

OK (45 tests, 45 assertions)

Generating code coverage report in PHPUnit XML format ... done [00:02.235]
php vendor/bin/phpunit --coverage-xml=tmp/coverage-xml   6.03s user 0.47s system 99% cpu 6.516 total

vs xdebug:

➜  phpstan-src git:(2.1.x) ✗ time XDEBUG_MODE=coverage php vendor/bin/phpunit --coverage-xml=tmp/coverage-xml tests/PHPStan/Rules/Api/
PHPUnit 11.5.43 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.27 with Xdebug 3.4.7
Configuration: /Users/staabm/workspace/phpstan-src/phpunit.xml
Random Seed:   1763448849

.............................................                     45 / 45 (100%)

Time: 00:13.721, Memory: 184.00 MB

OK (45 tests, 45 assertions)

Generating code coverage report in PHPUnit XML format ... done [00:04.217]
XDEBUG_MODE=coverage php vendor/bin/phpunit --coverage-xml=tmp/coverage-xml   17.47s user 0.56s system 99% cpu 18.057 total

@ondrejmirtes
Copy link
Member

ondrejmirtes commented Nov 18, 2025

Please do not forget to update PHPUnit dependencies under tests/ as well. That's where paratest is installed I think.

@ondrejmirtes ondrejmirtes merged commit 19c50eb into phpstan:2.1.x Nov 18, 2025
362 of 366 checks passed
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Nov 18, 2025

Thank you!

@staabm staabm deleted the up-tok branch November 18, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@staabm @ondrejmirtes