Comparison with strtolower() etc. leads lower/upper-case-string#4857
Open
staabm wants to merge 9 commits intophpstan:2.1.xfrom
Open
Comparison with strtolower() etc. leads lower/upper-case-string#4857staabm wants to merge 9 commits intophpstan:2.1.xfrom
staabm wants to merge 9 commits intophpstan:2.1.xfrom
Conversation
staabm
commented
Feb 3, 2026
Collaborator
|
This pull request has been marked as ready for review. |
Contributor
Author
|
@VincentLanglet would love your feedback, as you implemented lowser/upper case handling IIRC |
VincentLanglet
suggested changes
Feb 3, 2026
| { | ||
| if (strtolower($s) === 'hallo') { | ||
| assertType('non-falsy-string', $s); | ||
| assertType('lowercase-string&non-falsy-string', $s); |
Contributor
There was a problem hiding this comment.
This is wrong, it's not because strtolower($s) is a lowerstring than $s is a lowercase string.
It's only the case if $s === strtolower($something)
Contributor
Author
There was a problem hiding this comment.
you are right. I mixed up the operands 🫣
VincentLanglet
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#14047