Use res.headersSent to detect if the headers have been sent#15
Closed
mcollina wants to merge 1 commit intopillarjs:masterfrom
Closed
Use res.headersSent to detect if the headers have been sent#15mcollina wants to merge 1 commit intopillarjs:masterfrom
mcollina wants to merge 1 commit intopillarjs:masterfrom
Conversation
Contributor
|
Nice, thanks @mcollina ! Not sure how I missed the use of |
Contributor
Author
|
I'm wondering how @sebdeckers found it too :D. |
dougwilson
approved these changes
May 17, 2017
|
@mcollina 🕵️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sebdeckers found this in nodejs/http2#130.
This PR updates the module so that it uses a public documented property wherever possible.
I do not think this is fully working with the http2 core module, as it is destroying the socket, while you would have to destroy the stream in case of http2. We will address that later on.