[Kernel scoping 3/5] Add selectors to tracepoint deployment #1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e447b07 to
a7f6699
Compare
Signed-off-by: Benjamin Kilimnik <bkilimnik@pixielabs.ai>
a7f6699 to
4ceff57
Compare
ddelnano
reviewed
Sep 21, 2023
Member
ddelnano
left a comment
There was a problem hiding this comment.
A few minor comments, but otherwise looks good.
src/vizier/services/metadata/controllers/tracepoint/tracepoint.go
Outdated
Show resolved
Hide resolved
src/vizier/services/metadata/controllers/tracepoint/tracepoint.go
Outdated
Show resolved
Hide resolved
Comment on lines
440
to
443
| agentIDs := make([]uuid.UUID, len(validAgentsForProgram)) | ||
| for i, agt := range validAgentsForProgram { | ||
| agentIDs[i] = utils.UUIDFromProtoOrNil(agt.Info.AgentID) | ||
| } |
Member
There was a problem hiding this comment.
Instead of creating this agentdIDs slice twice (line 403 and here), what if we made agentsHashToAgents a make(map[string][]struct{*agentpb.Agent, uuid.UUID}). That would avoid looping over it a second time and duplicating the UUID conversion.
…rror case to parseKernelVersion, remove comment Signed-off-by: Benjamin Kilimnik <bkilimnik@pixielabs.ai>
Signed-off-by: Benjamin Kilimnik <bkilimnik@pixielabs.ai>
ddelnano
reviewed
Sep 21, 2023
Comment on lines
448
to
453
| agentIDs := validAgentsForProgram.AgentIDs | ||
| for i, agt := range validAgentsForProgram.Agents { | ||
| agentIDs[i] = utils.UUIDFromProtoOrNil(agt.Info.AgentID) | ||
| } | ||
|
|
||
| err = m.agtMgr.MessageAgents(agentIDs, msg) |
Member
There was a problem hiding this comment.
Isn't this for loop redundant now? I was hoping we would be able to remove it entirely and write the following:
err = m.agtMgr.MessageAgents(validAgentsForProgram.AgentIDs, msg)
Member
Author
There was a problem hiding this comment.
Yes sorry, I forgot to remove that loop. Should be fixed now.
Signed-off-by: Benjamin Kilimnik <bkilimnik@pixielabs.ai>
Signed-off-by: Benjamin Kilimnik <bkilimnik@pixielabs.ai>
ddelnano
approved these changes
Sep 21, 2023
Member
|
@pixie-io/maintainers this is ready for review now. |
JamesMBartlett
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds selectors to
TracepointDeploymentand modifies query broker to deploy tracepoints only to agents with matching selectors. Currently intended to fix #1582, but can capture other restrictions (OS version etc.) in the future.Related issues: #1582 #1659
Type of change: /kind feature
Test Plan: Tested all existing targets and tested selection based on kernel version in
src/vizier/services/metadata/controllers/tracepoint/tracepoint_test.go