xworkspaces: Deal with disappearing windows#2655
Merged
patrick96 merged 1 commit intopolybar:hotfix/3.6.2from Mar 20, 2022
Merged
xworkspaces: Deal with disappearing windows#2655patrick96 merged 1 commit intopolybar:hotfix/3.6.2from
patrick96 merged 1 commit intopolybar:hotfix/3.6.2from
Conversation
aa4185d to
fa99dda
Compare
Because the X server is asynchronous, there is no guarantee that after reading _NET_CLIENT_LIST, all windows still exist. For that reason we need to handle XCB_WINDOW errors appropriately.
Codecov Report
@@ Coverage Diff @@
## hotfix/3.6.2 #2655 +/- ##
================================================
- Coverage 13.78% 13.78% -0.01%
================================================
Files 153 153
Lines 11270 11272 +2
================================================
Hits 1554 1554
- Misses 9716 9718 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Because the X server is asynchronous, there is no guarantee that after
reading _NET_CLIENT_LIST, all windows still exist.
For that reason we need to handle XCB_WINDOW errors appropriately.
Related Issues & Documents
Documentation (check all applicable)