Dropwizard apply label mapper to snapshot metrics #1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c2b6cb to
6f52c40
Compare
Member
|
allowing subclassing is a slippery slope - I'd rather accept a help message customizer function in a builder |
bcb83d2 to
c779c07
Compare
Contributor
Author
I reverted the getHelpMessage change as it is only a nice to have. |
Signed-off-by: Kacper Filutowski <kacper.filutowski@tomtom.com>
Signed-off-by: Kacper Filutowski <kacper.filutowski@tomtom.com>
This reverts commit 6f52c40. Signed-off-by: Kacper Filutowski <kacper.filutowski@tomtom.com>
2cf062e to
392bc67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allowed to override getHelpMessage