Simplify Producer/Subscriber interfaces and adjust to match other libraries#470
Merged
Simplify Producer/Subscriber interfaces and adjust to match other libraries#470
Producer/Subscriber interfaces and adjust to match other libraries#470Conversation
This is to prefer be explicit when sending objects to a stream and to match the signatures of Redis publish() or Kafka-python send().
A publisher shim to a third-party message broker should not really be responsible to closing subscribers to the third-party message broker. This is because it's reasonable to expect the publisher and subscribers may come and go over time. This previous implementation detail of the Publisher/Subscriber protocol made specific instances unnecessarily coupled to each other. In the future, we may move this funtionality up to the higher level StreamProducer/StreamConsumer interfaces rather than required it to be implemented in every shim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify the
Producer/Subscriberinterfaces by removing the "closing a topic" logic, and maketopica required argument to methods.Fixes N/A
Type of Change
Testing
N/A
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., mypy, ruff, etc.).