Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the
populate_targetflag toStore.proxy()and other proxy methods of theStore. This flag "pre-resolves" the created proxies which essentially just sets the__wrapped__attribute of the proxy to reference the object that was proxied.I've added this flag because a common pattern in apps using ProxyStore is to create a proxy then pass that proxy to some compute engine that serializes the proxy. Often, these serializers introspect the proxy in some way which incidentally resolves the proxy. "Pre-resolving" the proxy removes the overhead that is often unknown to the programmer, and also avoids some issues with double resolving when
evict=True.Fixes
populate_targetflag toStore.proxy()and other proxy methods #499Type of Change
Testing
Added new tests.
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., mypy, ruff, etc.).