Skip to content

Comments

Copy target by default in borrow(), mut_borrow(), and into_owned()#506

Merged
gpauloski merged 1 commit intomainfrom
copy-target-references
Mar 6, 2024
Merged

Copy target by default in borrow(), mut_borrow(), and into_owned()#506
gpauloski merged 1 commit intomainfrom
copy-target-references

Conversation

@gpauloski
Copy link
Collaborator

Description

Copy target by default in borrow(), mut_borrow(), and into_owned(). This prevents the case of making many borrows that all have to be resolved again when the original reference was already resolved.

Fixes N/A

Type of Change

  • Breaking Change (fix or enhancement which changes existing semantics of the public interface)
  • Enhancement (new features or improvements to existing functionality)
  • Bug (fixes for a bug or issue)
  • Internal (refactoring, style changes, testing, optimizations)
  • Documentation update (changes to documentation or examples)
  • Package (dependencies, versions, package metadata)
  • Development (CI workflows, pre-commit, linters, templates)
  • Security (security related changes)

Testing

Added new test

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
  • Code changes pass pre-commit (e.g., mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski gpauloski added the bug Error, flaw, or fault that causes unexpected behavior label Mar 6, 2024
@gpauloski gpauloski merged commit 0c0fe1c into main Mar 6, 2024
@gpauloski gpauloski deleted the copy-target-references branch March 6, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Error, flaw, or fault that causes unexpected behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant