Fix submit() resolving RefProxy and RefMutProxy arguments#507
Merged
Fix submit() resolving RefProxy and RefMutProxy arguments#507
submit() resolving RefProxy and RefMutProxy arguments#507Conversation
Inserting a proxy into a set resolves it because it calls __hash__.
14 tasks
gpauloski
added a commit
that referenced
this pull request
Mar 9, 2024
Fix `submit()` resolving `Proxy` arguments (re: #507)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inserting a proxy into a set resolves it because it calls hash.
Description
submit()was resolvingRefProxyandRefMutProxyarguments because it adds those proxy types to a set. Inserting into a set calls__hash__which is forwarded to the target necessitating a resolve.This was fixed by appending the proxies to a list, and ensuring the callback can appropriately handle lists of reference proxies with duplicates.
I'm not happy about how much time I've lost debugging poor application performance due to this bug.
Fixes N/A
Type of Change
Testing
Added new unit tests.
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., mypy, ruff, etc.).