Change Globus user auth to use sub field#715
Conversation
|
Oh boy---thanks for finding this 😅. I think my intention was to use a unique field that wasn't the username since the username has some caveats. The username will be for their effective identity (i.e., for their default identity). This might cause issues if authenticated with one identity (e.g., UChicago) on machine A and a different identity (e.g., NERSC) on machine B. Maybe doing an intersection of |
|
Hmm, I haven't tried it, but I thought username would be fine. From the SDK docs, the |
|
I switched this PR to use |
6a07dcb to
1a36d45
Compare
sub field
|
Thanks for figuring that out! Will make a release and update the prod relay server this week. |
Description
The globus auth client id is the wrong field to use to validate the user. Instead, we change to use the sub which is unique to each globus identity.
Fixes
Type of Change
Testing
Changed the testing of authenticate to use the username.
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., mypy, ruff, etc.).