Add Python 3.13 (beta) support by bluetech · Pull Request #12334 · pytest-dev/pytest

bluetech · 2024-05-17T08:40:30Z

bluetech · 2024-05-17T08:42:35Z

src/_pytest/pytester.py

        i = 0
        entries = list(entries)
-        backlocals = sys._getframe(1).f_locals
+        # Since Python 3.13, f_locals is not a dict, but eval requires a dict.


https://discuss.python.org/t/pep-667-consistent-views-of-namespaces/46631/36

bluetech · 2024-05-17T08:43:01Z

src/_pytest/pytester.py

    ) -> Path:
        items = list(files.items())

+        if ext is None:


python/cpython#119113

bluetech · 2024-05-18T12:30:32Z

One remaining failure, on windows:

 ________________________ test_cache_reportheader[env1] ________________________

env = ('TOX_ENV_DIR', '/tox_env_dir')
pytester = <Pytester WindowsPath('C:/Users/runneradmin/AppData/Local/Temp/pytest-of-unknown/pytest-0/test_cache_reportheader1')>
monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x00000209B926A120>

    @pytest.mark.parametrize("env", ((), ("TOX_ENV_DIR", "/tox_env_dir")))
    def test_cache_reportheader(
        env: Sequence[str], pytester: Pytester, monkeypatch: MonkeyPatch
    ) -> None:
        pytester.makepyfile("""def test_foo(): pass""")
        if env:
            monkeypatch.setenv(*env)
            expected = os.path.join(env[1], ".pytest_cache")
        else:
            monkeypatch.delenv("TOX_ENV_DIR", raising=False)
            expected = ".pytest_cache"
        result = pytester.runpytest("-v")
>       result.stdout.fnmatch_lines([f"cachedir: {expected}"])
E       Failed: nomatch: 'cachedir: /tox_env_dir\\.pytest_cache'
E           and: '============================= test session starts ============================='
E           and: 'platform win32 -- Python 3.13.0b1, pytest-8.3.0.dev49+g87c7a72ce, pluggy-1.5.0 -- D:\\a\\pytest\\pytest\\.tox\\py313\\Scripts\\python.EXE'
E           and: 'cachedir: C:\\tox_env_dir\\.pytest_cache'
E           and: 'rootdir: C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-unknown\\pytest-0\\test_cache_reportheader1'
E           and: 'collecting ... collected 1 item'
E           and: ''
E           and: 'test_cache_reportheader.py::test_foo PASSED                              [100%]'
E           and: ''
E           and: '============================== 1 passed in 0.01s =============================='
E       remains unmatched: 'cachedir: /tox_env_dir\\.pytest_cache'

Probably something in os.path/pathlib changed.

RonnyPfannschmidt · 2024-05-18T12:37:31Z

Seems like its normalized/resolved now, so the env name is no longer correct

No need to support beta releases of an older version anymore. Ref: 09b2c95

bluetech · 2024-05-18T16:55:45Z

I don't know if the C:\ is correct or not, and I don't have windows handy, but since it's only for display, and probably tox doesn't issue such env dir path on windows anyway, so decided to sidestep the issue in the test.

This is ready for review, I'll also backport it for 8.2.1.

nicoddemus

Looks great, thanks for tackling this!

nicoddemus · 2024-05-18T17:22:29Z

src/_pytest/pytester.py

    ) -> Path:
        items = list(files.items())

+        if ext is None:


Let's leave a note here:

Suggested change

if ext is None:

# https://github.com/python/cpython/issues/119113

if ext is None:

I don't think it's necessary, since I think we better not rely on it and just keep the check.

I don't see what harm a small comment like that could cause either, but OK.

Also in that case, we probably should change the signature as well, so we have the typing match the runtime behavior.

The type is ext: str which is correct. The callers have some *args, **kwargs forwarding which is somewhat annoying to type.

Well OK, this is no big deal anyway.

nicoddemus · 2024-05-18T17:22:51Z

testing/code/test_excinfo.py

        excinfo = _pytest._code.ExceptionInfo.from_current()
    s = str(excinfo.traceback[-1])
-    assert s == "  File '<string>':1 in <module>\n  ???\n"
+    # TODO: Since Python 3.13b1 under pytest-xdist, the * is `import


I think so.

nicoddemus · 2024-05-18T18:34:32Z

changelog/12334.bugfix.rst

@@ -0,0 +1 @@
+Support for Python 3.13 (beta1 at the time of writing).


I would categorize this as a feature actually.

## Description `testcontainers-python` is not compatible with python 3.13 because of several packages. ## Related issues Fixes #870 ## Packages update - bump cffi: python-cffi/cffi#24 - bump psycopg2: psycopg/psycopg2#1695 - bump trio: python-trio/trio#2955 - bump pytest: pytest-dev/pytest#12334 - bump pymilvus: milvus-io/pymilvus#2684 - bump twine: pypa/twine#1184 - bump cryptography: pyca/cryptography#11491 - bump greenlet: python-greenlet/greenlet@9497948 (python-greenlet/greenlet#392) - bump grpcio: grpc/grpc#36201 - bump httpx: encode/httpx#3460 - bump ibm-db: ibmdb/python-ibmdb#971 - bump orjson: https://github.com/ijl/orjson/releases/tag/3.10.15 - bump pandas: https://github.com/pandas-dev/pandas/releases/tag/v2.2.3 > ⚠️ `cryptography` is not compatible with python `3.9.0` and `3.9.1` to be able to update to the version supporting Python 3.13 we have to exclude those version, meaning the minimum version is now 3.9.2 included. --------- Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com> Co-authored-by: David Ankin <daveankin@gmail.com>

bluetech mentioned this pull request May 17, 2024

Test failures on Python 3.13.0b1 #12323

Closed

bluetech commented May 17, 2024

View reviewed changes

bluetech force-pushed the py313 branch from 21dce63 to 0dd0fb8 Compare May 18, 2024 12:10

testing: remove conditionals for Python 3.11 beta releases

dbee3fa

No need to support beta releases of an older version anymore. Ref: 09b2c95

bluetech force-pushed the py313 branch from 3b5f2ed to 0c11cf0 Compare May 18, 2024 16:54

bluetech marked this pull request as ready for review May 18, 2024 16:55

bluetech changed the title ~~WIP: Add Python 3.13 (beta) support~~ Add Python 3.13 (beta) support May 18, 2024

nicoddemus approved these changes May 18, 2024

View reviewed changes

nicoddemus reviewed May 18, 2024

View reviewed changes

Add Python 3.13 (beta1) support

1cb704f

bluetech force-pushed the py313 branch from 0c11cf0 to 1cb704f Compare May 19, 2024 06:25

bluetech merged commit c1d623c into pytest-dev:main May 19, 2024

bluetech deleted the py313 branch May 19, 2024 06:45

bluetech added the backport 8.2.x label May 19, 2024

github-actions bot mentioned this pull request May 19, 2024

[8.2.x] Add Python 3.13 (beta) support #12340

Merged

data-sync-user mentioned this pull request Jun 3, 2024

Bump pytest from 8.1.1 to 8.2.1 MozillaFoundation/foundation.mozilla.org#12354

Closed

This was referenced Sep 9, 2025

chore(testing): adding python 3.13 support axel7083/testcontainers-python#2

Open

chore: add support for building with python 3.13 testcontainers/testcontainers-python#871

Merged

	if ext is None:
	# https://github.com/python/cpython/issues/119113
	if ext is None:

		@@ -0,0 +1 @@
		Support for Python 3.13 (beta1 at the time of writing).

Uh oh!

Conversation

bluetech commented May 17, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bluetech commented May 18, 2024

Uh oh!

RonnyPfannschmidt commented May 18, 2024

Uh oh!

bluetech commented May 18, 2024

Uh oh!

nicoddemus left a comment

Choose a reason for hiding this comment

Uh oh!

nicoddemus May 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

nicoddemus May 18, 2024 •

edited

Loading