GH-103082: Document PEP-669: Low Impact Monitoring for CPython#107772
Merged
markshannon merged 18 commits intopython:mainfrom Sep 5, 2023
Merged
GH-103082: Document PEP-669: Low Impact Monitoring for CPython#107772markshannon merged 18 commits intopython:mainfrom
markshannon merged 18 commits intopython:mainfrom
Conversation
4 tasks
Contributor
jacobtylerwalls
left a comment
There was a problem hiding this comment.
Spotted a typo while here, cheers
AA-Turner
reviewed
Aug 13, 2023
AA-Turner
reviewed
Sep 1, 2023
Member
AA-Turner
left a comment
There was a problem hiding this comment.
Suggestions to remove double-spaces, and to remove an unneeded sys.monitoring prefix from the function definitions -- they'll be added by Sphinx regardless as of the .. module:: directive at the top of the file, and removing them helps with line length/readability.
A
Member
|
The patch mentiond for diff --git a/Doc/conf.py b/Doc/conf.py
index 16fd8bf2571..901b977fd71 100644
--- a/Doc/conf.py
+++ b/Doc/conf.py
@@ -157,6 +157,8 @@
('envvar', 'USER'),
('envvar', 'USERNAME'),
('envvar', 'USERPROFILE'),
+ # sys.monitoring ignores
+ ('py:class', 'range(6)'),
]
# Temporary undocumented names. |
AA-Turner
reviewed
Sep 1, 2023
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Member
|
Is this getting backported to 3.12? |
Member
Author
|
Yes, it should be. |
Contributor
|
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
GH-108909 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 5, 2023
…ythonGH-107772) (cherry picked from commit 8b515f6) Co-authored-by: Mark Shannon <mark@hotpy.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial draft
📚 Documentation preview 📚: https://cpython-previews--107772.org.readthedocs.build/