gh-112720: make it easier to subclass and modify dis.ArgResolver's jump arg resolution #115564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r's jump arg resolution
iritkatriel
commented
Feb 16, 2024
iritkatriel
commented
Feb 16, 2024
markshannon
approved these changes
Feb 16, 2024
Member
markshannon
left a comment
There was a problem hiding this comment.
The changes looks good.
I'm a bit concerned that we are going to end up with an overly complex tool for presenting both bytecode and IR, when we might be better of with two tools. One for IR and one for code objects. What do you think?
Member
Author
I'm not sure. So far I don't think my changes made dis more complicated. They made it more structured (and configurable). |
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…r's jump arg resolution (python#115564)
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…r's jump arg resolution (python#115564)
LukasWoodtli
pushed a commit
to LukasWoodtli/cpython
that referenced
this pull request
Jan 22, 2025
…r's jump arg resolution (python#115564)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when using dis to display an intermediate, or custom, instruction stream. In that case the jump args may have different meaning than in actual bytecode.