gh-117503: Fix support of non-ASCII user names in posixpath.expanduser()#117504
Merged
serhiy-storchaka merged 1 commit intopython:mainfrom Apr 17, 2024
Merged
Conversation
…anduser() They are now supported in bytes paths as well as in string paths.
AlexWaygood
reviewed
Apr 3, 2024
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Apr 17, 2024
…ath.expanduser() (pythonGH-117504) They are now supported in bytes paths as well as in string paths. (cherry picked from commit 51132da) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-117970 is a backport of this pull request to the 3.12 branch. |
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…anduser() (pythonGH-117504) They are now supported in bytes paths as well as in string paths.
serhiy-storchaka
added a commit
that referenced
this pull request
Apr 17, 2024
Contributor
|
Hi @serhiy-storchaka - the newly added test fails when there are users with a trailing slash in their home path (which I think is allowed?): |
Member
Author
Contributor
|
Thank you for the fix - the issue is gone now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are now supported in bytes paths as well as in string paths.