Skip to content

gh-123229: Fix valgrind warning by initializing the f-string buffers to 0 in the tokenizer #123263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 1 commit into from
Aug 23, 2024
Merged

gh-123229: Fix valgrind warning by initializing the f-string buffers to 0 in the tokenizer #123263

pablogsal merged 1 commit into from
Aug 23, 2024

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Aug 23, 2024 •
edited by bedevere-app bot
Loading

@pablogsal pablogsal requested a review from lysnikolaou as a code owner August 23, 2024 12:07
@pablogsal pablogsal added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Aug 23, 2024
@bedevere-app bedevere-app bot mentioned this pull request Aug 23, 2024
Closed
@pablogsal
pythongh-123229: Fix valgrind warning by initializing the f-string bu…
ea5c1e3 
…ffers to 0 in the tokenizer

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@pablogsal pablogsal enabled auto-merge (squash) August 23, 2024 12:09
@pablogsal pablogsal merged commit adc5190 into python:main Aug 23, 2024
@pablogsal pablogsal deleted the gh-123229 branch August 23, 2024 12:33
@miss-islington-app
Copy link

miss-islington-app bot commented Aug 23, 2024

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2024
@pablogsal @miss-islington
pythongh-123229: Fix valgrind warning by initializing the f-string bu…
c60e64b 
…ffers to 0 in the tokenizer (pythonGH-123263)

(cherry picked from commit adc5190)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 23, 2024

GH-123264 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 23, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Aug 23, 2024

Sorry, @pablogsal, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker adc5190014efcf7b7a4c5dfc9998faa8345527ed 3.12

@bedevere-app
Copy link

bedevere-app bot commented Aug 23, 2024

GH-123265 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Aug 23, 2024
pablogsal added a commit to pablogsal/cpython that referenced this pull request Aug 23, 2024
@pablogsal
[3.12] pythongh-123229: Fix valgrind warning by initializing the f-st…
3b7eeef 
…ring buffers to 0 in the tokenizer (pythonGH-123263)

(cherry picked from commit adc5190)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Aug 23, 2024
@miss-islington @pablogsal
[3.13] gh-123229: Fix valgrind warning by initializing the f-string b…
935b8b4 
…uffers to 0 in the tokenizer (GH-123263) (#123264)

gh-123229: Fix valgrind warning by initializing the f-string buffers to 0 in the tokenizer (GH-123263)
(cherry picked from commit adc5190)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Aug 23, 2024
@pablogsal
[3.12] gh-123229: Fix valgrind warning by initializing the f-string b…
7dec3d7 
…uffers to 0 in the tokenizer (GH-123263) (#123265)

(cherry picked from commit adc5190)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 24, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 Refleaks 3.12 has failed when building commit 7dec3d7.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1158/builds/466) and take a look at the build logs.
  4. Check if the failure is related to this commit (7dec3d7) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1158/builds/466

Summary of the results of the build (if available):

Click to see traceback logs 
remote: Enumerating objects: 10, done.        
remote: Counting objects:  10% (1/10)        
remote: Counting objects:  20% (2/10)        
remote: Counting objects:  30% (3/10)        
remote: Counting objects:  40% (4/10)        
remote: Counting objects:  50% (5/10)        
remote: Counting objects:  60% (6/10)        
remote: Counting objects:  70% (7/10)        
remote: Counting objects:  80% (8/10)        
remote: Counting objects:  90% (9/10)        
remote: Counting objects: 100% (10/10)        
remote: Counting objects: 100% (10/10), done.        
remote: Compressing objects:  16% (1/6)        
remote: Compressing objects:  33% (2/6)        
remote: Compressing objects:  50% (3/6)        
remote: Compressing objects:  66% (4/6)        
remote: Compressing objects:  83% (5/6)        
remote: Compressing objects: 100% (6/6)        
remote: Compressing objects: 100% (6/6), done.        
remote: Total 10 (delta 4), reused 10 (delta 4), pack-reused 0 (from 0)        
From https://github.com/python/cpython
 * branch                  3.12       -> FETCH_HEAD
Note: switching to '7dec3d7acbb072e0d5cd7357c1ddf12d3c667e8a'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 7dec3d7acb [3.12] gh-123229: Fix valgrind warning by initializing the f-string buffers to 0 in the tokenizer (GH-123263) (#123265)
Switched to and reset branch '3.12'

make: *** [Makefile:2021: buildbottest] Terminated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pablogsal @bedevere-bot