Skip to content

bpo-35947: Fix a compiler warning in _ctypes.c's StructUnionType_paramfunc() #12629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 1 commit into from
Mar 31, 2019
Merged

bpo-35947: Fix a compiler warning in _ctypes.c's StructUnionType_paramfunc() #12629

serhiy-storchaka merged 1 commit into from
Mar 31, 2019

Conversation

@ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Mar 30, 2019 •
edited by bedevere-bot
Loading

With GCC 8.2.0, I see the following:

/home/lubuntu2/cpython/Modules/_ctypes/_ctypes.c: In function ‘StructUnionType_paramfunc’:
/home/lubuntu2/cpython/Modules/_ctypes/_ctypes.c:409:22: warning: comparison of integer expressions of different signedness: ‘Py_ssize_t’ {aka ‘long int’} and ‘long unsigned int’ [-Wsign-compare]
     if (self->b_size > sizeof(void*)) {
                      ^

This is due to 32119e1.

https://bugs.python.org/issue35947

zooba
zooba approved these changes Mar 30, 2019
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can't merge from my phone (broken UI), but if someone else wants to add skip-news and merge then go ahead.

@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Mar 31, 2019

Ping @zooba.

@serhiy-storchaka serhiy-storchaka merged commit 48600c7 into python:master Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ZackerySpytz @zooba @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot