GH-126920: fix Makefile overwriting sysconfig.get_config_vars #126922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Member
Author
|
I am not sure if we should backport this, as they may be users incorrectly relying on the value of I think it's a low chance, but since this bug does not seem to be causing any known breakage in the first place, it may be worth considering leaving older versions with the incorrect value rather than breaking users possibly relying on the current value being incorrect. 3.13 is still pretty recent and people are still getting around to updating to it — in Arch Linux, for reference, we are only now starting the package rebuilds for Python 3.13 — so I don't think there'd be much harm in backporting. 3.12, tough, I am not sure. @Yhg1s what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sysconfig.get_config_vars()values always get overwritten with the values fromMakefile#126920