Skip to content

bpo-36565: Fix libregrtest for Python without builtin _abc #12733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Apr 8, 2019
Merged

bpo-36565: Fix libregrtest for Python without builtin _abc #12733

vstinner merged 1 commit into from
Apr 8, 2019

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Apr 8, 2019 •
edited by bedevere-bot
Loading

Fix reference hunting (python3 -m test -R 3:3) when Python has no
built-in abc module: fix _get_dump() reimplementation of libregrtest.

https://bugs.python.org/issue36565

@vstinner
bpo-36565: Fix libregrtest for Python without builtin _abc
377f92d 
Fix reference hunting (``python3 -m test -R 3:3``) when Python has no
built-in abc module: fix _get_dump() reimplementation of libregrtest.
ilevkivskyi
ilevkivskyi approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner merged commit 79b5d29 into python:master Apr 8, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Apr 8, 2019

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@vstinner vstinner deleted the regrtest_abc branch April 8, 2019 23:36
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 8, 2019
@vstinner @miss-islington
bpo-36565: Fix libregrtest for Python without builtin _abc (pythonGH-…
4ee2705 
…12733)

Fix reference hunting (``python3 -m test -R 3:3``) when Python has no
built-in abc module: fix _get_dump() reimplementation of libregrtest.
(cherry picked from commit 79b5d29)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot
Copy link

bedevere-bot commented Apr 8, 2019

GH-12734 is a backport of this pull request to the 3.7 branch.

@vstinner
Copy link
Member Author

vstinner commented Apr 8, 2019

Thanks for the review @ilevkivskyi!

vstinner added a commit that referenced this pull request Apr 8, 2019
@miss-islington @vstinner
bpo-36565: Fix libregrtest for Python without builtin _abc (GH-12733) (…
2368d86 
…GH-12734)

Fix reference hunting (``python3 -m test -R 3:3``) when Python has no
built-in abc module: fix _get_dump() reimplementation of libregrtest.
(cherry picked from commit 79b5d29)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot
Copy link

bedevere-bot commented Apr 9, 2019

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.x has failed when building commit 79b5d29.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/141/builds/1498) and take a look at the build logs.
  4. Check if the failure is related to this commit (79b5d29) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/141/builds/1498

Click to see traceback logs 
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/_test_multiprocessing.py", line 4377, in test_wait_socket
    self.assertEqual(b''.join(v), expected)
AssertionError: b'1\n2\n3\n4\n5\n6\n7\n8\n9\n' != b'0\n1\n2\n3\n4\n5\n6\n7\n8\n9\n'

----------------------------------------------------------------------

Ran 344 tests in 93.592s

FAILED (failures=1, skipped=33)


Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/_test_multiprocessing.py", line 4377, in test_wait_socket
    self.assertEqual(b''.join(v), expected)
AssertionError: b'1\n2\n3\n4\n5\n6\n7\n8\n9\n' != b'0\n1\n2\n3\n4\n5\n6\n7\n8\n9\n'

----------------------------------------------------------------------

Ran 344 tests in 82.027s

FAILED (failures=1, skipped=33)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @miss-islington @bedevere-bot @ilevkivskyi @the-knights-who-say-ni