Skip to content

bpo-35360: Update macOS installer to use SQLite 3.28.0#14180

Merged
ned-deily merged 2 commits intomasterfrom
unknown repository
Jun 18, 2019
Merged

bpo-35360: Update macOS installer to use SQLite 3.28.0#14180
ned-deily merged 2 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jun 18, 2019 •
edited by bedevere-bot
Loading

@ghost ghost self-requested a review as a code owner June 18, 2019 01:01
ned-deily
ned-deily requested changes Jun 18, 2019
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. If you could make the requested changes for the NEWS entry, we can merge this in.

@bedevere-bot
Copy link

bedevere-bot commented Jun 18, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ned-deily ned-deily changed the title bpo-35360: Update OS X installer to use SQLite 3.28.0 bpo-35360: Update macOS installer to use SQLite 3.28.0 Jun 18, 2019
@ned-deily ned-deily mentioned this pull request Jun 18, 2019
Merged
@ghost
Copy link
Author

ghost commented Jun 18, 2019

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Jun 18, 2019

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

@ned-deily ned-deily merged commit d8f336f into python:master Jun 18, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Jun 18, 2019

Thanks @animalize for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jun 18, 2019

GH-14195 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2019
@miss-islington
bpo-35360: Update macOS installer to use SQLite 3.28.0 (pythonGH-14180)
413ffaa 
(cherry picked from commit d8f336f)

Co-authored-by: animalize <animalize@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Jun 18, 2019

GH-14196 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jun 18, 2019
@miss-islington
bpo-35360: Update macOS installer to use SQLite 3.28.0 (GH-14180)
a7072ff 
(cherry picked from commit d8f336f)

Co-authored-by: animalize <animalize@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jun 18, 2019
@miss-islington
bpo-35360: Update macOS installer to use SQLite 3.28.0 (GH-14180)
624c9a2 
(cherry picked from commit d8f336f)

Co-authored-by: animalize <animalize@users.noreply.github.com>
@ghost ghost deleted the sqlite_mac branch June 19, 2019 01:03
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@lisroach
bpo-35360: Update macOS installer to use SQLite 3.28.0 (pythonGH-14180)
6f6bacd
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@DinoV
bpo-35360: Update macOS installer to use SQLite 3.28.0 (pythonGH-14180)
85e9d76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bedevere-bot @miss-islington @ned-deily @the-knights-who-say-ni @wjssz