Skip to content

bpo-38353: Fix compiler warning in pycore_initconfig.h #16570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Oct 3, 2019
Merged

bpo-38353: Fix compiler warning in pycore_initconfig.h #16570

vstinner merged 1 commit into from
Oct 3, 2019

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 3, 2019 •
edited by bedevere-bot
Loading

Use "_PyRuntimeState" with "struct pyruntimestate" to avoid a warning
on typedef re-definition.

https://bugs.python.org/issue38353

@vstinner
bpo-38353: Fix compiler warning in pycore_initconfig.h
f0ee98d 
Use "_PyRuntimeState" with "struct pyruntimestate" to avoid a warning
on typedef re-definition.
@vstinner vstinner merged commit c515b57 into python:master Oct 3, 2019
@vstinner vstinner deleted the fix_include_warn branch October 3, 2019 22:43
@bedevere-bot
Copy link

bedevere-bot commented Oct 3, 2019

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.x has failed when building commit c515b57.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/3/builds/3617) and take a look at the build logs.
  4. Check if the failure is related to this commit (c515b57) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/3/builds/3617

Failed tests:

  • test_regrtest

Summary of the results of the build (if available):

== Tests result: FAILURE then SUCCESS ==

389 tests OK.

10 slowest tests:

  • test_mmap: 6 min
  • test_io: 4 min
  • test_largefile: 2 min 55 sec
  • test_multiprocessing_spawn: 2 min 52 sec
  • test_tools: 2 min 49 sec
  • test_tokenize: 2 min 18 sec
  • test_concurrent_futures: 1 min 44 sec
  • test_unicodedata: 1 min 22 sec
  • test_lib2to3: 1 min 17 sec
  • test_asyncio: 1 min 10 sec

30 tests skipped:
test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_epoll
test_fcntl test_fork1 test_gdb test_grp test_ioctl test_kqueue
test_multiprocessing_fork test_multiprocessing_forkserver test_nis
test_openpty test_ossaudiodev test_pipes test_poll test_posix
test_pty test_pwd test_readline test_resource test_spwd
test_syslog test_threadsignals test_wait3 test_wait4
test_xxtestfuzz test_zipfile64

1 re-run test:
test_regrtest

Total duration: 27 min 35 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\support\__init__.py", line 336, in _force_run
    return func(*args)
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'D:\\buildarea\\3.x.bolen-windows10\\build\\build\\test_python_9260\\test_python_worker_11168'


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\runpy.py", line 192, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "D:\buildarea\3.x.bolen-windows10\build\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\__main__.py", line 2, in <module>
    main()
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\libregrtest\main.py", line 712, in main
    Regrtest().main(tests=tests, **kwargs)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\libregrtest\main.py", line 634, in main
    self._main(tests, kwargs)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\contextlib.py", line 131, in __exit__
    self.gen.throw(type, value, traceback)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\support\__init__.py", line 1101, in temp_cwd
    yield cwd_dir
  File "D:\buildarea\3.x.bolen-windows10\build\lib\contextlib.py", line 131, in __exit__
    self.gen.throw(type, value, traceback)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\support\__init__.py", line 1054, in temp_dir
    rmtree(path)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\support\__init__.py", line 458, in rmtree
    _rmtree(path)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\support\__init__.py", line 399, in _rmtree
    _waitfor(_rmtree_inner, path, waitall=True)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\support\__init__.py", line 347, in _waitfor
    func(pathname)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\support\__init__.py", line 396, in _rmtree_inner
    _force_run(fullname, os.rmdir, fullname)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\support\__init__.py", line 342, in _force_run
    return func(*args)
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'D:\\buildarea\\3.x.bolen-windows10\\build\\build\\test_python_9260\\test_python_worker_11168'


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\support\__init__.py", line 1049, in temp_dir
    yield path
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\support\__init__.py", line 1101, in temp_cwd
    yield cwd_dir
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\libregrtest\main.py", line 634, in main
    self._main(tests, kwargs)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\libregrtest\main.py", line 707, in _main
    sys.exit(0)
SystemExit: 0

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@vstinner
bpo-38353: Fix compiler warning in pycore_initconfig.h (pythonGH-16570)
76c7b41 
Replace "_PyRuntimeState" with "struct pyruntimestate" to avoid
a warning on typedef re-definition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @bedevere-bot @the-knights-who-say-ni