Skip to content

bpo-38353: Simplify calculate_pybuilddir() #16614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Oct 7, 2019
Merged

bpo-38353: Simplify calculate_pybuilddir() #16614

vstinner merged 1 commit into from
Oct 7, 2019

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 7, 2019 •
edited by bedevere-bot
Loading

Calling _Py_wfopen() is enough to check if filename is an existing
file or not. There is no need to check first isfile().

https://bugs.python.org/issue38353

@vstinner
bpo-38353: Simplify calculate_pybuilddir()
373b097 
Calling _Py_wfopen() is enough to check if filename is an existing
file or not. There is no need to check first isfile().
@vstinner
Copy link
Member Author

vstinner commented Oct 7, 2019

The pybuilddir.txt configuration file was introduced by https://bugs.python.org/issue9589 with commit e9b428f:

commit e9b428f9977f8733e6b0d2c321c093779f95080f
Author: Antoine Pitrou <solipsis@pitrou.net>
Date:   Fri Aug 13 22:25:01 2010 +0000

    Reimplement addbuilddir() in C inside getpath.c, so as to execute it
    at interpreter startup before importing any non-builtin modules.
    Should fix #9589.

The code evolved a lot since 2010 which made the isfile() call redundant.

cc @pitrou

@vstinner vstinner merged commit b96145a into python:master Oct 7, 2019
@vstinner vstinner deleted the pybuilddir2 branch October 7, 2019 10:57
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@vstinner
bpo-38353: Simplify calculate_pybuilddir() (pythonGH-16614)
9a88884 
Calling _Py_wfopen() is enough to check if filename is an existing
file or not. There is no need to check first isfile().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot