Skip to content

bpo-38353: Fix typos in calculate_argv0_path_framework() #16695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Oct 10, 2019
Merged

bpo-38353: Fix typos in calculate_argv0_path_framework() #16695

vstinner merged 1 commit into from
Oct 10, 2019

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 10, 2019 •
edited by bedevere-bot
Loading

bpo-38353, bpo-38429: Fix typos introduced by commit
c02b41b in
calculate_argv0_path_framework() of getpath.c.

https://bugs.python.org/issue38353

@vstinner
bpo-38353: Fix typos in calculate_argv0_path_framework()
4f21cd0 
bpo-38353, bpo-38429: Fix typos introduced by commit
c02b41b in
calculate_argv0_path_framework() of getpath.c.
@vstinner
Copy link
Member Author

vstinner commented Oct 10, 2019

I never tried Python with --enable-framework. It updated my PR to fix more issues. The compilation now pass.

But when I run Python from the source directory, I get this error:

$ ./python.exe -m test test_embed  -v
dyld: Library not loaded: /Library/Frameworks/Python.framework/Versions/3.9/Python
  Referenced from: /Users/haypo/python/master/./python.exe
  Reason: image not found
Abort trap: 6

I guess that it's normal, Python should be installed. Or maybe I should use --enable-shared as well.

@vstinner vstinner merged commit b6e0fc7 into python:master Oct 10, 2019
@vstinner vstinner deleted the getpath_framework branch October 10, 2019 13:42
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@vstinner
bpo-38353: Fix typos in calculate_argv0_path_framework() (pythonGH-16695
875b733 
)

bpo-38353, bpo-38429: Fix typos introduced by commit
c02b41b in
calculate_argv0_path_framework() of getpath.c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot