bpo-30411: git doesn't support "-C" args under 1.8.5 occurs in configure.ac #1680
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
I have autoconf at version 1.13.4, that cause aclocal.m4 have some different outputs. But this file is generated by autoreconf, so should I suppose it will be ok? |
ned-deily
left a comment
There was a problem hiding this comment.
I agree with @zhangyangyu 's suggestion in the bug tracker to unconditionally use --git-dir instead. That should work with older versions of git and does not break building from a separate srcdir. Also, either use a current version of autoconf to create configure or let the core-developer do it so that there aren't spurious changes to configure. In any case, you should revert the changes to aclocal.m4.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Close this since long time no reaction. I'll make a new one on my own. (I have asked the owner personally, he is my friend.) |
git doesn't support "-C" args under 1.8.5 occurs in configure.ac
as I noticed from git release notes in 1.8.5:
to go there before doing anything else.
So we should have some conditional statements in configure.ac around git checkpoint, otherwise we got error message which is :
Unknown option: -C
usage: git [--version] [--help] [-c name=value]
[--exec-path[=]] [--html-path] [--man-path] [--info-path]
[-p|--paginate|--no-pager] [--no-replace-objects] [--bare]
[--git-dir=] [--work-tree=] [--namespace=]
[]
https://bugs.python.org/issue30411