Skip to content

bpo-34679: ProactorEventLoop only uses set_wakeup_fd() in main thread #16901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Oct 23, 2019
Merged

bpo-34679: ProactorEventLoop only uses set_wakeup_fd() in main thread #16901

vstinner merged 1 commit into from
Oct 23, 2019

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 23, 2019 •
edited by bedevere-bot
Loading

bpo-34679, bpo-38563: asyncio.ProactorEventLoop.close() now only calls
signal.set_wakeup_fd() in the main thread.

https://bugs.python.org/issue34679

@vstinner
bpo-34679: ProactorEventLoop only uses set_wakeup_fd() in main thread
a822eae 
bpo-34679, bpo-38563: asyncio.ProactorEventLoop.close() now only calls
signal.set_wakeup_fd() in the main thread.
@vstinner
Copy link
Member Author

vstinner commented Oct 23, 2019

I didn't test my PR manually on Windows, but I added a test which should test it on the CI.

@vstinner vstinner merged commit 1b53a24 into python:master Oct 23, 2019
@vstinner vstinner deleted the proactor_set_wakeup_fd branch October 23, 2019 15:25
@miss-islington
Copy link
Contributor

miss-islington commented Oct 23, 2019

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 23, 2019

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

miss-islington commented Oct 23, 2019

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

bedevere-bot commented Oct 23, 2019

GH-16902 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 23, 2019
@miss-islington @vstinner
bpo-34679: ProactorEventLoop only uses set_wakeup_fd() in main thread (…
cbf474c 
…GH-16901)

bpo-34679, bpo-38563: asyncio.ProactorEventLoop.close() now only calls
signal.set_wakeup_fd() in the main thread.
(cherry picked from commit 1b53a24)

Co-authored-by: Victor Stinner <vstinner@python.org>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@vstinner
bpo-34679: ProactorEventLoop only uses set_wakeup_fd() in main thread (…
258a409 
…pythonGH-16901)

bpo-34679, bpo-38563: asyncio.ProactorEventLoop.close() now only calls
signal.set_wakeup_fd() in the main thread.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@vstinner @shihai1991
bpo-34679: ProactorEventLoop only uses set_wakeup_fd() in main thread (…
99b6abc 
…pythonGH-16901)

bpo-34679, bpo-38563: asyncio.ProactorEventLoop.close() now only calls
signal.set_wakeup_fd() in the main thread.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes

@asvetlov asvetlov asvetlov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vstinner @miss-islington @bedevere-bot @1st1 @asvetlov @the-knights-who-say-ni