bpo-38588: Optimize list comparison. #17766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitigate performance regression of the list comparison caused by 2d5bf56.
Member
|
Edit: Sorry, I checked and it should not affect it. |
pablogsal
approved these changes
Dec 31, 2019
Member
pablogsal
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the analysis and the quick fix Inada-san.
And apologies for missing the comment in bpo.
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Mitigate performance regression of the list comparison caused by 2d5bf56.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigate performance regression of the list comparison caused by
2d5bf56.
https://bugs.python.org/issue38588