Skip to content

bpo-39209: Manage correctly multi-line tokens in interactive mode #17860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 2 commits into from
Jan 6, 2020
Merged

bpo-39209: Manage correctly multi-line tokens in interactive mode #17860

pablogsal merged 2 commits into from
Jan 6, 2020

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jan 6, 2020 •
edited by bedevere-bot
Loading

@pablogsal
Copy link
Member Author

pablogsal commented Jan 6, 2020

CC: @corona10

Could you check if this fixes the problem on your system?

@corona10
Copy link
Member

corona10 commented Jan 6, 2020

@pablogsal I will report it by today :)

@corona10
Copy link
Member

corona10 commented Jan 6, 2020

@pablogsal Work correctly with this PR :)

corona10
corona10 approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pablogsal pablogsal self-assigned this Jan 6, 2020
@pablogsal pablogsal merged commit 5ec91f7 into python:master Jan 6, 2020
@pablogsal pablogsal deleted the bpo-39209 branch January 6, 2020 15:59
@miss-islington
Copy link
Contributor

miss-islington commented Jan 6, 2020

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

bedevere-bot commented Jan 6, 2020

GH-17867 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jan 6, 2020
@miss-islington @pablogsal
bpo-39209: Manage correctly multi-line tokens in interactive mode (GH…
b2e281a 
…-17860)

(cherry picked from commit 5ec91f7)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@pablogsal @shihai1991
bpo-39209: Manage correctly multi-line tokens in interactive mode (py…
b3a2686 
…thonGH-17860)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

+1 more reviewer

@asottile asottile asottile approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pablogsal @corona10 @miss-islington @bedevere-bot @asottile @the-knights-who-say-ni