Skip to content

[3.7] bpo-39932: Fix multiprocessing test_heap() #19690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Apr 23, 2020
Merged

[3.7] bpo-39932: Fix multiprocessing test_heap() #19690

vstinner merged 1 commit into from
Apr 23, 2020

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Apr 23, 2020 •
edited by bedevere-bot
Loading

_TestHeap now creates a new Heap() object for each test run.
Partial backport of commit e4679cd
by Antoine Pitrou.

https://bugs.python.org/issue39932

@vstinner
Copy link
Member Author

vstinner commented Apr 23, 2020

On aarch64 RHEL8 Refleaks 3.7 buildbot worker, I can easily reproduce https://bugs.python.org/issue39932 with the following command in a few seconds:

./python -m test test_multiprocessing_fork -R 3:3 -j8 -F -m test.test_multiprocessing_fork.WithProcessesTestHeap.test_heap

With this change, the test is now reliable: no failure after 56 runs (1 minute).

@vstinner
bpo-39932: Fix multiprocessing test_heap()
d27a476 
Fix multiprocessing test_heap(): a new Heap object is now created
for each test run.

Partial backport of commit e4679cd
by Antoine Pitrou.
@vstinner vstinner merged commit 857d573 into python:3.7 Apr 23, 2020
@vstinner vstinner deleted the test_heap37 branch April 23, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot