Skip to content

Conversation

@uriyyo
Copy link
Member

@uriyyo uriyyo commented Nov 29, 2020

Remove deprecated loop parameter from docs.

https://bugs.python.org/issue42392

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 29, 2020
@uriyyo uriyyo changed the title bpo-42392: Remove deprecated *loop* parameter from docs bpo-42392: Remove deprecated loop parameter from docs Nov 29, 2020
@uriyyo
Copy link
Member Author

uriyyo commented Nov 29, 2020

@1st1 @asvetlov Can you please add skip-news label?

@uriyyo
Copy link
Member Author

uriyyo commented Nov 29, 2020

Deprecated since version 3.8, removed in version 3.10: The loop parameter.

@1st1 @asvetlov I have found information in docs that asyncio.Task loop parameter is deprecated, link to the docs.

Is this a mistake in docs or there were no deprecation warning regarding loop parameter in asyncio.Task class?

@asvetlov
Copy link
Contributor

It is a soft-deprecation.

Ideally, a user should never create a task by the constructor call but always use loop.create_task() or asyncio.create_task().

Not sure what should we do with docs here.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@uriyyo
Copy link
Member Author

uriyyo commented Nov 29, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

@asvetlov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants