bpo-43172: readline now passes its tests when built against libedit #24499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing irreconcilable API differences remain in readline.get_begidx and eadline.get_endidx behavior based on libreadline vs libedit use.
Member
Author
|
There isn't anyone who'd consider themselves an expert on this ancient module's internals as far as I can see... mostly waiting on CI tests and any other pair of C focused eyeballs. |
Member
Author
|
buildbot tests look good, the three red ones are unrelated. |
Member
|
Sorry @gpshead, I was sick last days and wasn't available for reviews. But I see that you managed to merge your PR, cool! It's good to see libedit supported on more platforms ;-) |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…ythonGH-24499) bpo-43172: readline now passes its tests when built against libedit. Existing irreconcilable API differences remain in readline.get_begidx and readline.get_endidx behavior based on libreadline vs libedit use. A note about that has been documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing irreconcilable API differences remain in readline.get_begidx and readline.get_endidx behavior based on libreadline vs libedit use.
https://bugs.python.org/issue43172