bpo-43725: Add CI step to check changes in the exported ABI#25188
bpo-43725: Add CI step to check changes in the exported ABI#25188pablogsal wants to merge 1 commit intopython:masterfrom
Conversation
311b675 to
953b0f1
Compare
|
Unfortunately seems that doing this check with two different compiler versions produce some different DWARF and the tool identifies the differences as errors :( |
gpshead
left a comment
There was a problem hiding this comment.
Neat, lets try it out! I suppose this shows up as a non-blocking check by default? Release branch owners can presumably decide if this is reliable enough to make it blocking.
|
I will try to investigate how to overcome this:
|
|
@gpshead Check my message in https://bugs.python.org/msg390213 with the analysis of this solution. |
|
|
||
| check_abi: | ||
| name: 'Check if the ABI has changed' | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
I'd pin the runner, to ensure that the job runs with at least the same major GCC version every time. Ref. bpo-43382.
https://bugs.python.org/issue43725