bpo-44653: Support typing.Union in parameter substitution of the union type #27232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d57f09e to
a74e69f
Compare
Member
Fidget-Spinner
left a comment
There was a problem hiding this comment.
LGTM but please see my message on the bpo. There is another bug in the substitution.
| @@ -0,0 +1 @@ | |||
| Support ``typing.Union`` in parameter substitution of the union type. | |||
Member
There was a problem hiding this comment.
Maybe this is more specific:
Suggested change
| Support ``typing.Union`` in parameter substitution of the union type. | |
| Flatten ``typing.Union`` during parameter substitution of the union type. |
Member
Author
There was a problem hiding this comment.
Is it better? Before this PR typing.Union was not supported at all.
Member
There was a problem hiding this comment.
Hmm oh right I forgot. I think it's good to also mention that the arguments are flattened though, since none of the other types are treated like that. Some people might expect (int | T)[Union[str, int]] to become int | Union[str, int].
Suggested change
| Support ``typing.Union`` in parameter substitution of the union type. | |
| Support ``typing.Union`` in parameter substitution of the union type. | |
| Arguments in ``typing.Union`` are flattened and merged into the | |
| union type. |
Member
Author
|
There is more general approach in #27247. |
Contributor
|
Closing in favor of GH-27247. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue44653