Skip to content

bpo-45655: Add ref to union-type expressions at top of typing docs #29309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fidget-Spinner merged 1 commit into from
Oct 29, 2021
Merged

bpo-45655: Add ref to union-type expressions at top of typing docs #29309

Fidget-Spinner merged 1 commit into from
Oct 29, 2021

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Oct 29, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 29, 2021
@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Oct 29, 2021

Please link to the previous issue 45655 in your title (bpo-XXX).

@AlexWaygood AlexWaygood changed the title Add ref to union-type expressions at top of typing docs bpo-45655 Add ref to union-type expressions at top of typing docs Oct 29, 2021
@AlexWaygood
Copy link
Member Author

AlexWaygood commented Oct 29, 2021

Please link to the previous issue 45655 in your title (bpo-XXX).

Done, sorry!

Fidget-Spinner
Fidget-Spinner approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, sorry!

Thanks! No worries.

@Fidget-Spinner Fidget-Spinner changed the title bpo-45655 Add ref to union-type expressions at top of typing docs bpo-45655: Add ref to union-type expressions at top of typing docs Oct 29, 2021
@Fidget-Spinner Fidget-Spinner merged commit d957521 into python:main Oct 29, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Oct 29, 2021

Thanks @AlexWaygood for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 29, 2021
@AlexWaygood @miss-islington
bpo-45655: Add ref to union type expressions at top of typing docs (p…
0bb5dc9 
…ythonGH-29309)

(cherry picked from commit d957521)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 29, 2021

GH-29312 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 29, 2021
@AlexWaygood AlexWaygood deleted the patch-2 branch October 29, 2021 13:57
miss-islington added a commit that referenced this pull request Oct 29, 2021
@miss-islington @AlexWaygood
bpo-45655: Add ref to union type expressions at top of typing docs (G…
6742b0d 
…H-29309)

(cherry picked from commit d957521)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AlexWaygood @Fidget-Spinner @miss-islington @bedevere-bot @the-knights-who-say-ni